Refactoring of history code. #1328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanslenders
force-pushed
the
history-refactoring
branch
6 times, most recently
from
110c51b to
1c066d9
Compare
- Fix race condition in ThreadedHistory. Fixes issue #1158. - Refactored the history code so that asynchronous history loader implementations become possible. - Start loading the history when the `BufferControl` renders for the first time. This way we are sure that the history loading uses the same event loop as the one used by the application. (Important for tools like ptpython where the `Application` can run in a different thread.) - Added unit tests. - Make it possible to wrap `InMemoryHistory` in `ThreadedHistory` (not that useful, but good if all combinations work). - Use a deque for the working lines in buffer.py -> much better performance when reloading the history. Special thanks to "Bob Hyman <bob.hyman@gmail.com>" for the original implementations of an improved history and script for reproducing issue #1158.
jonathanslenders
force-pushed
the
history-refactoring
branch
from
1c066d9 to
6035997
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementations become possible.
BufferControlrenders for the firsttime. This way we are sure that the history loading uses the same event loop
as the one used by the application.
InMemoryHistoryinThreadedHistory(not useful,but good if all combinations work).